Skip to content

chore: updated rc release flow #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2022
Merged

chore: updated rc release flow #1005

merged 5 commits into from
Jun 24, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jun 23, 2022

Description of your changes

This PR proposes a change that modifies the lerna command that is in charge of versioning. This command is executed as part of the release action/workflow. The change in this PR adds two flags that allow to perform pre-releases with a custom suffix.

The two flags added are:

  • --conventional-prerelease
  • --preid rc, this flag allows to set a custom suffix so that pre-releases will look like 0.11.0-rc.0

The documentation for both flags can be found here.

How to verify this change

npx lerna version --conventional-commits --force-publish --conventional-prerelease --preid rc --yes
lerna notice cli v4.0.0
lerna info current version 0.10.0
lerna WARN force-publish all packages
lerna info Assuming all packages changed
lerna info getChangelogConfig Successfully resolved preset "conventional-changelog-angular"

Changes:
 - cdk-app: 0.10.0 => 0.11.0-rc.0
 - powertools-typescript-sam-example: 0.10.0 => 0.11.0-rc.0
 - @aws-lambda-powertools/commons: 0.10.0 => 0.11.0-rc.0
 - @aws-lambda-powertools/logger: 0.10.0 => 0.11.0-rc.0
 - @aws-lambda-powertools/metrics: 0.10.0 => 0.11.0-rc.0
 - @aws-lambda-powertools/tracer: 0.10.0 => 0.11.0-rc.0

... Additional log entries removed for brevity's sake

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi requested review from flochaz and saragerion June 23, 2022 14:47
@dreamorosi dreamorosi self-assigned this Jun 23, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jun 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

📊 Package size report   0.02%↑

File Before After
aws-lambda-powertools-commons-0.10.0.tgz 6.5 kB
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.10.0.tgz 23.7 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.10.0.tgz 17.5 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.10.0.tgz 21.4 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
tracer-bundle.zip 21.9 kB 0.1%↑21.9 kB
Total (Includes all files) 140.1 kB 0.02%↑140.2 kB
Tarball size 138.9 kB 0.04%↑139.0 kB
Unchanged files
File Size
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 8c0cc8bce0c93148d3ae94508e4febcd)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.1 kB 140.1 kB
Tarball size 138.9 kB 0.02%↑138.9 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB
tracer-bundle.zip 21.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: a29276f4962e0d8e3236951844f0683c)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.1 kB 140.1 kB
Tarball size 138.9 kB 0%↑138.9 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB
tracer-bundle.zip 21.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 83923e3b5e5769049dfc4681de46e6c4)

@dreamorosi
Copy link
Contributor Author

I have no idea why the pr-lint-and-test on Node 12 is failing, I haven't modified anything except the .github/on-release-prod.yml file

saragerion
saragerion previously approved these changes Jun 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.1 kB 140.1 kB
Tarball size 138.9 kB 0%↑138.9 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB
tracer-bundle.zip 21.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: e698e0f431f623be335c0ba6c828ebcc)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.1 kB 140.1 kB
Tarball size 138.9 kB 0%↑138.9 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB
tracer-bundle.zip 21.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 1f6c0acbbfd01383d4c0d79536406ed1)

@dreamorosi dreamorosi force-pushed the chore/add_rc_tag branch 2 times, most recently from 00183c3 to d70b753 Compare June 23, 2022 18:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

📊 Package size report   No changes

File Before After
Total (Includes all files) 140.1 kB 140.1 kB
Tarball size 138.9 kB -0%↓138.9 kB
Unchanged files
File Size
aws-lambda-powertools-commons-0.11.0.tgz 6.5 kB
aws-lambda-powertools-logger-0.11.0.tgz 23.7 kB
aws-lambda-powertools-metrics-0.11.0.tgz 17.5 kB
aws-lambda-powertools-tracer-0.11.0.tgz 21.4 kB
commons-bundle.zip 7.0 kB
logger-bundle.zip 24.2 kB
metrics-bundle.zip 18.0 kB
tracer-bundle.zip 21.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 80bb043db1982032241b1fe27da9869e)

@dreamorosi dreamorosi requested review from flochaz and saragerion June 24, 2022 08:54
@dreamorosi dreamorosi merged commit d957cd6 into main Jun 24, 2022
@dreamorosi dreamorosi deleted the chore/add_rc_tag branch June 24, 2022 09:55
dreamorosi added a commit that referenced this pull request Aug 2, 2022
* chore: updated rc release flow

* chore: removed useless flag

* Revert "chore: removed useless flag"

This reverts commit e5e2ec6.

* test new update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants